Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera move to model #2126

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Fix camera move to model #2126

merged 1 commit into from
Sep 7, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 7, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#330

Summary

Fixed moving to model by casting model entity id to the correct type.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #2126 (b0c1394) into gz-sim7 (5ebf860) will decrease coverage by 0.01%.
Report is 2 commits behind head on gz-sim7.
The diff coverage is n/a.

❗ Current head b0c1394 differs from pull request most recent head f4fdb42. Consider uploading reports for the commit f4fdb42 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #2126      +/-   ##
===========================================
- Coverage    65.01%   65.01%   -0.01%     
===========================================
  Files          356      356              
  Lines        28929    28929              
===========================================
- Hits         18808    18807       -1     
- Misses       10121    10122       +1     

see 1 file with indirect coverage changes

📢 Have feedback on the report? Share it here.

@mjcarroll mjcarroll merged commit 9055d88 into gz-sim7 Sep 7, 2023
@mjcarroll mjcarroll deleted the fix_move_to_model branch September 7, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz-sim: Move Camera to model
3 participants