Remove major version from package name #2726
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update cmake project name, package.xml name * Remove version from cmake target names * Change examples to find_package(gz-sim) and update target names. Signed-off-by: Steve Peters <[email protected]>
Update tests and examples to import gz.sim Signed-off-by: Steve Peters <[email protected]>
|
@osrf-jenkins run tests please |
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
scpeters
force-pushed
the
scpeters/package_name_without_major_version
branch
from
81082df to
1f21013
Compare
Signed-off-by: Steve Peters <[email protected]>
scpeters
force-pushed
the
scpeters/package_name_without_major_version
branch
from
1f21013 to
9cfe829
Compare
|
I saw what looked like a flaky test, confirmed that it flakes locally, reported it in #2727, and restarted the job with the test failure |
|
I think gazebo-tooling/release-tools#1246 would fix the windows CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of gazebo-tooling/release-tools#1244.
Summary
This removes the major version from the package name in the following places:
find_packagecalls in examples and tutorialsimportstatements in tests, examples, and tutorialsTest it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.