Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update log tutorials #386

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Update log tutorials #386

merged 1 commit into from
Sep 28, 2020

Conversation

JShep1
Copy link

@JShep1 JShep1 commented Sep 26, 2020

The justification for the removal of log_playback.sdf is in this issue: #293 . I think we should probably make a tutorial for logging now.

Signed-off-by: John Shepherd [email protected]

Signed-off-by: John Shepherd <[email protected]>
@JShep1 JShep1 requested a review from chapulina as a code owner September 26, 2020 22:17
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 26, 2020
@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #386 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   77.19%   77.19%           
=======================================
  Files         200      200           
  Lines       10709    10709           
=======================================
  Hits         8267     8267           
  Misses       2442     2442           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0042e...56cdda1. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call 👍

@chapulina chapulina merged commit c45ab06 into master Sep 28, 2020
@chapulina chapulina deleted the jshep1/update_log_examples branch September 28, 2020 17:46
@adlarkin adlarkin mentioned this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants