Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions to #281 #508

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Suggestions to #281 #508

merged 1 commit into from
Dec 23, 2020

Conversation

chapulina
Copy link
Contributor

  • The --record command line flag wasn't working, this fixed it
  • Added some test expectations
  • Improved some common::joinPaths usage
  • Fixed documentation for IGN_GAZEBO_SERVER_CONFIG_PATH env var

@chapulina
Suggestions to #281
826aaa2 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the 🏰 citadel Ignition Citadel label Dec 21, 2020
@chapulina chapulina requested a review from mjcarroll December 21, 2020 20:52
@mjcarroll
Copy link
Contributor

I'm going to fix the broken tests on my branch.

@mjcarroll mjcarroll merged commit e15b673 into default_plugin_loading Dec 23, 2020
@mjcarroll mjcarroll deleted the chapulina/default_plugin_loading branch December 23, 2020 17:27
mjcarroll pushed a commit that referenced this pull request Jan 6, 2021
@chapulina @mjcarroll
Suggestions to #281 (#508)
33e91f7 
Signed-off-by: Louise Poubel <[email protected]>
mjcarroll pushed a commit that referenced this pull request Jan 6, 2021
@chapulina @mjcarroll
Suggestions to #281 (#508)
4a07ecd 
Signed-off-by: Louise Poubel <[email protected]>
mjcarroll pushed a commit that referenced this pull request Jan 6, 2021
@chapulina @mjcarroll
Suggestions to #281 (#508)
79d3a2d 
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll pushed a commit that referenced this pull request Jan 7, 2021
@chapulina
Merged in bump_4 (pull request #508)
4989abb 
Bump default to 4.0.0

Approved-by: Louise Poubel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@maryaB-osr maryaB-osr Awaiting requested review from maryaB-osr

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @mjcarroll