Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set protocol version to 1.10 #1076

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Set protocol version to 1.10 #1076

merged 1 commit into from
Jul 12, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

The protocol version needs to be set so that the latest version is used.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested review from azeey and scpeters as code owners July 12, 2022 01:29
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 12, 2022
@chapulina chapulina mentioned this pull request Jul 12, 2022
9 tasks
@adityapande-1995
Copy link
Contributor

Thanks ! Maybe thats why CI was failing here : #1050

@chapulina chapulina enabled auto-merge (squash) July 12, 2022 01:32
@chapulina chapulina mentioned this pull request Jul 12, 2022
9 tasks
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1076 (1e7a73d) into main (ce712c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1076   +/-   ##
=======================================
  Coverage   83.12%   83.12%           
=======================================
  Files         154      154           
  Lines       18702    18702           
=======================================
  Hits        15546    15546           
  Misses       3156     3156           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce712c8...1e7a73d. Read the comment docs.

@chapulina chapulina merged commit 033b9bb into main Jul 12, 2022
@chapulina chapulina deleted the chaulina/13/protocol branch July 12, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants