Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy 1.9 spec to 1.10 #1073

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Copy 1.9 spec to 1.10 #1073

merged 2 commits into from
Jul 11, 2022

Conversation

scpeters
Copy link
Member

🎉 New feature

Create new minor version of spec 1.10 for Garden, needed by several new features.

Summary

There are a few new features proposed for the spec in Garden, so let's bump the minor version.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from azeey as a code owner July 11, 2022 18:26
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 11, 2022
@scpeters
Copy link
Member Author

cmake warning fixed in #1074

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1073 (2ec5669) into main (51e19d7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1073   +/-   ##
=======================================
  Coverage   83.12%   83.12%           
=======================================
  Files         154      154           
  Lines       18702    18702           
=======================================
  Hits        15546    15546           
  Misses       3156     3156           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e19d7...2ec5669. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, follows the pattern from #568.

@chapulina chapulina merged commit ce712c8 into main Jul 11, 2022
@chapulina chapulina deleted the scpeters/spec_1_10 branch July 11, 2022 23:49
@chapulina chapulina mentioned this pull request Jul 12, 2022
8 tasks
@chapulina
Copy link
Contributor

While adding to the 1.10 spec, I noticed this change was missing:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants