Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdf/1.10: remove unused spec files #1113

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes #635.

Summary

The urdf.sdf and collision_engine.sdf files are not included by any other spec file, so they can be removed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

The urdf.sdf and collision_engine.sdf files are not
included by any other spec file, so they can be removed.

Fixes #635.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from azeey as a code owner August 18, 2022 19:15
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #1113 (65f5226) into sdf13 (1af61c9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            sdf13    #1113   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files         125      125           
  Lines       15892    15892           
=======================================
  Hits        13781    13781           
  Misses       2111     2111           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters merged commit 1bf1aa4 into sdf13 Aug 18, 2022
@scpeters scpeters deleted the scpeters/remove_unused_spec_files branch August 18, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants