Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser.cc update calls to use sdf::Errors output #1294

Merged
merged 20 commits into from
Aug 25, 2023
Merged

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Jun 22, 2023

🎉 New feature

Work towards #820.

Summary

Adds missing sdf::Errors structure as an option to report errors on parser.cc. Makes sure that no errors are printed and all are reported through the structure when using the functions that include it as parameter.

Test it

Call the functions that report sdf::Errors through a parameter and no errors should be printed but only reported through the sdf structure.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Marco A. Gutierrez added 7 commits May 29, 2023 03:52
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
@marcoag marcoag requested review from azeey and scpeters as code owners June 22, 2023 10:34
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1294 (7d2ee4c) into sdf13 (e55378e) will decrease coverage by 0.10%.
The diff coverage is 65.54%.

❗ Current head 7d2ee4c differs from pull request most recent head fe2c105. Consider uploading reports for the commit fe2c105 to get more accurate results

@@            Coverage Diff             @@
##            sdf13    #1294      +/-   ##
==========================================
- Coverage   87.68%   87.58%   -0.10%     
==========================================
  Files         128      128              
  Lines       16989    17090     +101     
==========================================
+ Hits        14896    14968      +72     
- Misses       2093     2122      +29     
Files Changed Coverage Δ
src/parser.cc 85.63% <64.95%> (-1.22%) ⬇️
src/Error.cc 100.00% <100.00%> (ø)
src/Root.cc 95.21% <100.00%> (ø)

include/sdf/Error.hh Outdated Show resolved Hide resolved
include/sdf/Error.hh Outdated Show resolved Hide resolved
include/sdf/parser.hh Outdated Show resolved Hide resolved
include/sdf/parser.hh Outdated Show resolved Hide resolved
src/parser.cc Outdated Show resolved Hide resolved
src/parser.cc Show resolved Hide resolved
src/parser.cc Show resolved Hide resolved
src/parser_private.hh Outdated Show resolved Hide resolved
test/integration/includes.cc Outdated Show resolved Hide resolved
test/integration/includes.cc Outdated Show resolved Hide resolved
Marco A. Gutierrez and others added 2 commits June 27, 2023 11:50
Signed-off-by: Marco A. Gutierrez <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
@marcoag marcoag force-pushed the sdf_error_parser branch from f6cce06 to b3e55a8 Compare June 27, 2023 11:51
Marco A. Gutierrez and others added 5 commits June 27, 2023 20:06
Co-authored-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
Marco A. Gutierrez and others added 4 commits August 16, 2023 16:42
@azeey azeey mentioned this pull request Aug 23, 2023
@marcoag marcoag merged commit b999425 into sdf13 Aug 25, 2023
@marcoag marcoag deleted the sdf_error_parser branch August 25, 2023 04:57
@azeey
Copy link
Collaborator

azeey commented Aug 30, 2023

This was merged with Merge-commit. Let's remember to use Squash commit for feature PRs next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants