-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser.cc update calls to use sdf::Errors output #1294
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf13 #1294 +/- ##
==========================================
- Coverage 87.68% 87.58% -0.10%
==========================================
Files 128 128
Lines 16989 17090 +101
==========================================
+ Hits 14896 14968 +72
- Misses 2093 2122 +29
|
azeey
reviewed
Jun 24, 2023
9 tasks
Signed-off-by: Marco A. Gutierrez <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Marco A. Gutierrez <[email protected]>
marcoag
force-pushed
the
sdf_error_parser
branch
from
June 27, 2023 11:51
f6cce06
to
b3e55a8
Compare
Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Marco A. Gutierrez <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
… sdf_error_parser
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merged
…tions Suggestions for #1294
azeey
approved these changes
Aug 24, 2023
This was merged with Merge-commit. Let's remember to use Squash commit for feature PRs next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta
Targeting beta release of upcoming collection
🌱 garden
Ignition Garden
🎵 harmonic
Gazebo Harmonic
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Work towards #820.
Summary
Adds missing
sdf::Errors
structure as an option to report errors onparser.cc
. Makes sure that no errors are printed and all are reported through the structure when using the functions that include it as parameter.Test it
Call the functions that report
sdf::Errors
through a parameter and no errors should be printed but only reported through the sdf structure.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.