-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDF.cc update calls to use sdf::Errors output #1295
Conversation
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
This PR depends on #1294 for the tests to pass since they check nothing is printed. |
This function signature was kept (even though is not public) because otherwise it would involve further changes in |
include/sdf/Error.hh
Outdated
@@ -179,6 +179,9 @@ namespace sdf | |||
|
|||
/// \brief Generic error during parsing. | |||
PARSING_ERROR, | |||
|
|||
/// \brief File not found error. | |||
FILE_NOT_FOUND, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a review thread in #1296 (comment) recommends using FILE_READ
instead of adding a new enum for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened #1442 targeting this branch to use FILE_READ
instead of a new enum
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @scpeters!!
🎉 New feature
Work towards #820.
Summary
Adds missing
sdf::Errors
structure as an option to report errors onSDF
. Makes sure that no errors are printed and all are reported through the structure when using the functions that include it as parameter.Test it
Call the functions that report
sdf::Errors
through a parameter and no errors should be printed but only reported through the sdf structure.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.