-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sensor DOM to Element functions and add tests #757
Conversation
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf12 #757 +/- ##
==========================================
+ Coverage 88.57% 88.62% +0.04%
==========================================
Files 76 76
Lines 11740 11781 +41
==========================================
+ Hits 10399 10441 +42
+ Misses 1341 1340 -1
Continue to review full report at Codecov.
|
@azeey , are you okay with this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🦟 Bug fix
Fixes #
Summary
Renamed
PopulateElement()
toToElement()
based on feedback from pull request #755The
PopulateElement
functions were added in #753 and have not been released yet so this should not break API/ABI.Added unit tests.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge