Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USD to SDF: material fixed #895

Merged
merged 11 commits into from
Mar 24, 2022
Merged

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Mar 22, 2022

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

  • Set the workflow type
  • remove the texture file before copy it if this already exists
  • Avoid find resources in the local path

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde added the usd label Mar 22, 2022
@ahcorde ahcorde requested a review from adlarkin March 22, 2022 09:39
@ahcorde ahcorde requested review from azeey and scpeters as code owners March 22, 2022 09:39
@ahcorde ahcorde self-assigned this Mar 22, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #895 (c60ebc9) into sdf12 (ae5c4d6) will decrease coverage by 0.09%.
The diff coverage is 55.26%.

@@            Coverage Diff             @@
##            sdf12     #895      +/-   ##
==========================================
- Coverage   88.12%   88.02%   -0.10%     
==========================================
  Files         100      100              
  Lines       14667    14692      +25     
==========================================
+ Hits        12925    12933       +8     
- Misses       1742     1759      +17     
Impacted Files Coverage Δ
usd/src/usd_parser/USDMaterial.cc 59.44% <55.26%> (-4.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae5c4d6...c60ebc9. Read the comment docs.

@ahcorde
Copy link
Collaborator Author

ahcorde commented Mar 22, 2022

@osrf-jenkins retest this please

1 similar comment
@ahcorde
Copy link
Collaborator Author

ahcorde commented Mar 22, 2022

@osrf-jenkins retest this please

@ahcorde ahcorde requested a review from adlarkin March 23, 2022 12:00
usd/src/usd_parser/USDMaterial.cc Outdated Show resolved Hide resolved
usd/src/usd_parser/USDMaterial.cc Outdated Show resolved Hide resolved
usd/src/usd_parser/USDMaterial.cc Outdated Show resolved Hide resolved
usd/src/usd_parser/USDMaterial.cc Outdated Show resolved Hide resolved
usd/src/usd_parser/USDMaterial.cc Show resolved Hide resolved
usd/src/usd_parser/USDMaterial.cc Outdated Show resolved Hide resolved
@ahcorde ahcorde requested a review from adlarkin March 23, 2022 21:53
Signed-off-by: ahcorde <[email protected]>
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one final question.

usd/src/usd_parser/USDData_TEST.cc Outdated Show resolved Hide resolved
@ahcorde ahcorde requested a review from adlarkin March 24, 2022 10:58
@adlarkin adlarkin merged commit b235400 into sdf12 Mar 24, 2022
@adlarkin adlarkin deleted the ahcorde/usd_to_sdf/material_fixes branch March 24, 2022 15:10
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress usd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants