-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USD to SDF: Added Collisions #898
Conversation
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: ahcorde <[email protected]>
… ahcorde/usd_to_sdf_transforms
…nto ahcorde/usd_to_sdf_lights
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
… ahcorde/usd_to_sdf_transforms
Signed-off-by: ahcorde <[email protected]>
…nto ahcorde/usd_to_sdf_lights
Signed-off-by: ahcorde <[email protected]>
… ahcorde/usd_to_sdf_transforms
…nto ahcorde/usd_to_sdf_lights
Signed-off-by: ahcorde <[email protected]>
… ahcorde/usd_to_sdf_transforms
…nto ahcorde/usd_to_sdf_lights
Signed-off-by: ahcorde <[email protected]>
…hcorde/usd_to_sdf_visuals
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
… ahcorde/usd_to_sdf_collisions
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, I left a few minor comments below. Would you mind adding tests?
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf12 #898 +/- ##
==========================================
- Coverage 86.73% 86.57% -0.16%
==========================================
Files 106 108 +2
Lines 15450 15528 +78
==========================================
+ Hits 13401 13444 +43
- Misses 2049 2084 +35
Continue to review full report at Codecov.
|
🎉 New feature
Summary
Added collisions to USD -> SDF converter
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.