require the cli component of ign-utils for usd component #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashton Larkin <[email protected]>
ahcorde
approved these changes
Mar 23, 2022
Codecov Report
@@ Coverage Diff @@
## sdf12 #908 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 100 100
Lines 14667 14667
=======================================
Hits 12925 12925
Misses 1742 1742 Continue to review full report at Codecov.
|
scpeters
approved these changes
Mar 23, 2022
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
When doing some testing of the USD component in a clean docker container, I found that I was able to invoke cmake and attempt to build the USD component without installing the
clicomponent ofign-utils. This resulted in a build error because the following headers couldn't be found:I've updated the cmake code to make sure that the
clicomponent ofign-utilsis installed before the user tries to build the usd component.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.