Added Plane Python interface #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
This was referenced Apr 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #941 +/- ##
==========================================
- Coverage 87.99% 87.98% -0.01%
==========================================
Files 106 107 +1
Lines 14826 14849 +23
==========================================
+ Hits 13046 13065 +19
- Misses 1780 1784 +4
Continue to review full report at Codecov.
|
|
@osrf-jenkins retest this please |
This was referenced Apr 7, 2022
|
@osrf-jenkins retest this please |
Signed-off-by: ahcorde <[email protected]>
…otics/sdformat into ahcorde/python/plane
scpeters
reviewed
Apr 14, 2022
python/src/sdf/pyPlane.cc
Outdated
| "for a Visual or Collision object, then the normal is specified in " | ||
| "the Visual or Collision frame, respectively.") | ||
| .def("set_normal", &sdf::Plane::SetNormal, | ||
| "Set the plane normal vector. The _normal vector will be " |
There was a problem hiding this comment.
nit: _normal -> normal here and in Plane.hh`
scpeters
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde [email protected]
🎉 New feature
This PR is part of this meta ticket #931
Summary
Added Plane Python interface
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.