Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 9 -> 12 #965

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Merge 9 -> 12 #965

merged 4 commits into from
Apr 12, 2022

Conversation

scpeters
Copy link
Member

➡️ Forward port

Port sdf9 to sdf12

Branch comparison: sdf12...sdf9

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

WilliamLewww and others added 4 commits March 29, 2022 20:01
Signed-off-by: Ian Chen <[email protected]>

Co-authored-by: Ashton Larkin <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
* Ported changes from #936
* Removed quick return logic

Signed-off-by: Aditya <[email protected]>
@scpeters scpeters requested a review from azeey as a code owner April 11, 2022 23:51
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #965 (54310d0) into sdf12 (a0b022d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            sdf12     #965      +/-   ##
==========================================
- Coverage   86.73%   86.73%   -0.01%     
==========================================
  Files         106      106              
  Lines       15451    15450       -1     
==========================================
- Hits        13402    13401       -1     
  Misses       2049     2049              
Impacted Files Coverage Δ
src/ign.cc 73.93% <100.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0b022d...54310d0. Read the comment docs.

@scpeters scpeters merged commit c1afd7f into sdf12 Apr 12, 2022
@scpeters scpeters deleted the merge_9_12 branch April 12, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants