Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make git a dependency optional #195

Closed
hoshsadiq opened this issue Nov 25, 2018 · 5 comments
Closed

Make git a dependency optional #195

hoshsadiq opened this issue Nov 25, 2018 · 5 comments
Labels
buildkit Moby BuildKit

Comments

@hoshsadiq
Copy link

Just tried this out as I'm trying to build a VM with minimal dependencies with runc and containerd et al (i.e. without docker).

While trying to run img to build an image, it failed due to git not being installed. Is there a reason for git being a requirement?

# img build -t x11 .
Building docker.io/library/test:latest
Setting up the rootfs... this may take a bit.
[+] Building 0.0s (0/0)
creating worker failed: failed to find git binary: exec: "git": executable file not found in $PATH

Would be nice to make this optional.

@unkaktus
Copy link
Contributor

unkaktus commented Nov 25, 2018

AFAIK buildkit itself depends on git binary and not img.

@AkihiroSuda AkihiroSuda added the buildkit Moby BuildKit label Nov 26, 2018
AkihiroSuda added a commit to AkihiroSuda/buildkit_poc that referenced this issue Nov 28, 2018
@AkihiroSuda
Copy link
Collaborator

PR: moby/buildkit#737

@hoshsadiq
Copy link
Author

Can this be closed now that buildkit has it merged?

@AkihiroSuda
Copy link
Collaborator

Not vendored yet

@AkihiroSuda
Copy link
Collaborator

closing via #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildkit Moby BuildKit
Projects
None yet
Development

No branches or pull requests

3 participants