Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker/base: allow running without git installed #737

Merged
merged 1 commit into from
Nov 29, 2018
Merged

worker/base: allow running without git installed #737

merged 1 commit into from
Nov 29, 2018

Conversation

AkihiroSuda
Copy link
Member

genuinetools/img#195

Signed-off-by: Akihiro Suda [email protected]

@AkihiroSuda AkihiroSuda mentioned this pull request Nov 28, 2018
Closed
@fuweid
Copy link
Contributor

fuweid commented Nov 28, 2018

LGTM

tonistiigi
tonistiigi approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On longer term we should support running git in a container instead and pulling it externally.

@tonistiigi tonistiigi merged commit 75c4dff into moby:master Nov 29, 2018
@thaJeztah thaJeztah mentioned this pull request Dec 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AkihiroSuda @fuweid @tonistiigi