checkedGroup only seems to work with baseLayers #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartvde
pushed a commit
to bartvde/gxp2
that referenced
this pull request
Mar 18, 2014
…io groups depends on geoext/geoext2#242
|
TIA for any review, I'll open up a new ticket for the css issue, but I don't have a good solution for that as yet (currently I'm simply overriding it in the application css). |
|
see #243 for the css issue |
|
Looks good to me. |
mpriour
added a commit
that referenced
this pull request
Mar 18, 2014
checkedGroup only seems to work with baseLayers
|
thanks @mpriour ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GeoExt 1 we had the enforceOnce function.
When using a checkedGroup in combination with allOverlays (the default in GeoExt), you can get more than one item in the group checked currently.
Also the checkbox css does not work well (look nice) with other themes such as Neptune.