Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radio in tree uses image from default theme #243

Merged
merged 2 commits into from
Mar 24, 2014

Conversation

bartvde
Copy link
Member

@bartvde bartvde commented Mar 24, 2014

So if you're using another theme such as Neptune, it won't look nice.

For now I'm using a css override but interested to hear ideas of something that could work for any theme.

.gx-tree-radio {
    background-image: url('http://docs.sencha.com/extjs/4.2.2/extjs-build/resources/ext-theme-neptune/images/form/radio.png');
}

@marcjansen
Copy link
Member

Hey @bartvde, would you be able to submit a PR, that adds your CSS to the API-Docs?

@marcjansen
Copy link
Member

Is #228 related?

@bartvde
Copy link
Member Author

bartvde commented Mar 24, 2014

hey @marcjansen I will do that if you can confirm that you also see no other solution?

@marcjansen
Copy link
Member

No, for now I do not see an alternative.

Your solution though is a perfectly valid workaround and should IMHO simply be documented prominently. Also we should possibly activate the workaround for our examples.

@bartvde
Copy link
Member Author

bartvde commented Mar 24, 2014

@marcjansen see attached PR for a fix to the tree.css instead, I think this is better than the doc fix

@marcjansen
Copy link
Member

Great!

Which icon will be used when a custom (user-built) theme is in use? Should we have the current icon as a fallback (e.g. via a less-specific CSS-rule)? Or is this simply something we need to document?

Feel free to merge with or without fallback-CSS.

Thanks for the continued work on this.

@bartvde
Copy link
Member Author

bartvde commented Mar 24, 2014

@marcjansen you were right we need a fallback class which I just added

bartvde pushed a commit that referenced this pull request Mar 24, 2014
radio in tree uses image from default theme (r=@marcjansen)
@bartvde bartvde merged commit 8b5b862 into geoext:master Mar 24, 2014
@bartvde bartvde deleted the tree-radio branch March 24, 2014 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants