Add timezone support #5061

juanluisrp · 2020-09-30T06:15:51Z

Before that, GeoNetwork was storing dates in the database in server timezone. Depending on the configuration dates could be displayed in a timezone which is different from the user timezone.

To improve that situation, this improvements adds:

The server time zone parameter is used to set the timezone of all dates not having a timezone specified

The default timezone of a fresh GeoNetwork installation will be UTC.
The user interface can define which timezone to use to render dates. For the simple case, it is recommended to set the server timezone and the user interface timezone to the same value it there is no need of multiple timezone support. browser can be used to render dates in current user timezone

Record view / settings to set the user timezone or (by default) use the browser timezone

Editor / Add timezone support

Remove Joda time library and use standard Java 8 java.time classes.
Migration / After setting the server timezone parameter, use v402.DateTimeMigrationTask migration task to update all db timezone.

This also means that when you create a new record, save and close, you don't have the status "updated one hour ago". If the title was not changed, it also contains the timezone information:

jodygarnett · 2020-09-30T15:04:44Z

Please pick up the ISODateTest timezone test from #5037

juanluisrp · 2020-11-30T14:57:22Z

Checked LinkStatus lastUpdate:

GeoNetwork UI
Database

UI is truncating the time to :00 seconds. Is that expected?

Remove Joda time library and use standard Java 8 java.time classes. Part of #1970 (#1970).

Force entity to be saved. ``` [ERROR] Failures: [ERROR] GeonetRepositoryTest.testBatchUpdateAttributes:125 expected:<[Updated DataElem]> but was:<[<md>metadata12</md>]> [ERROR] MetadataRepositoryTest.testIncrementPopularity:95 expected:<33> but was:<32> ``` We don't really know why this is required and how it is linked to the Joda removal.

Use: * `Browser` to use browser timezone * otherwise define a specific timezone to use to display date eg. `Australia/Hobart` Add: * Timezone directive / now support search by offset * Timezone directive / display more values

Test working locally but not on travis: ``` [ERROR] UrlAnalyzerTest.urlCheckerToSetStatus:250 expected:<12> but was:<6> ```

…dex field name for popularity.

Add code removed from MetadataUtils to XslUtils See commit a5a6cd7

jodygarnett · 2020-12-08T18:14:28Z

There is no great approach for dates without time, except perhaps storing them as a string, and then unpacking them as a date in the current timezone when asked.

Any attempt to limit them to a specific timezone is going to end up with glitches like metadata101/iso19139.ca.HNAP#135

Interpret the dates/ date-times appearing in the XML document as the timezone set in the settings if the string hasn't a explicit time offset.

This commit adds a migration of the DateTime zones from the zone defined in system timezone setting to UTC in case the date in the database doesn't have a explicit timezone.

juanluisrp · 2020-12-16T15:02:40Z

I've added a database migration to transform dates that don't have timezone defined into UTC dates using the system timezone setting.
Currently this migration isn't called automatically. It should be called manually using the /tools/migration/steps/v402.DateTimeMigrationTask API call once the administrator has set the right value in the server timezone setting.

ianwallen · 2020-12-16T17:23:35Z

@juanluisrp I did a quick test of the changes and I noticed that the dates are not showing up for the status history.
Before the changes I get the following

With the changes from this PR I see the following.

Changes the behaviour introduced in #5144 [1] and uses the timezone setting to print the date/time in new created metadata adding the timezone to the date. For example "2020-12-17T03:58:29.074-05:00[America/Toronto]". [1] #5144

…d by Java task.

juanluisrp · 2020-12-17T16:44:50Z

@juanluisrp I did a quick test of the changes and I noticed that the dates are not showing up for the status history.
Before the changes I get the following

Fixed @ianwallen

ianwallen · 2021-02-25T10:55:37Z

Any plans to backport this to the master/3.12?

@juanluisrp
I tested the status history with the latest 4.x changes and don't see the status history times. So it does not seem to have been fixed correctly?

juanluisrp · 2021-02-25T11:31:32Z

I will check it @ianwallen.

juanluisrp mentioned this pull request Sep 30, 2020

Date handling Improvement #1970

Closed

10 tasks

juanluisrp force-pushed the remove-joda-time branch from a3fbf91 to 5d843b3 Compare October 8, 2020 06:53

fxprunayre linked an issue Oct 19, 2020 that may be closed by this pull request

Date handling Improvement #1970

Closed

10 tasks

fxprunayre added this to the 4.0.0 milestone Oct 19, 2020

fxprunayre changed the title ~~Remove Joda time library~~ Date handling Improvement Oct 20, 2020

fxprunayre modified the milestones: 4.0.0, 4.0.1 Oct 20, 2020

fxprunayre mentioned this pull request Oct 23, 2020

Problème d'import de MEF SPW-DIG/metawal-core-geonetwork#555

Closed

fxprunayre modified the milestones: 4.0.1, 4.0.2 Nov 6, 2020

fxprunayre mentioned this pull request Nov 23, 2020

Inconsistencies showing date in xml, default display mode, and full display mode metadata101/iso19139.ca.HNAP#135

Open

juanluisrp force-pushed the remove-joda-time branch 2 times, most recently from c540c41 to b31ac31 Compare November 23, 2020 07:30

juanluisrp and others added 15 commits December 2, 2020 16:06

Remove Joda time library

f814800

Remove Joda time library and use standard Java 8 java.time classes. Part of #1970 (#1970).

Remove Joda time and legacy java.util.Date and Calendar uses

63b3dcc

Fix failing tests

c4bf35d

Clean old commented code

f822500

Refactor formatter as constant field

e308825

Date / UI / Add timezone configuration.

90289f5

Use: * `Browser` to use browser timezone * otherwise define a specific timezone to use to display date eg. `Australia/Hobart` Add: * Timezone directive / now support search by offset * Timezone directive / display more values

Date / UI / Editor / Add timezone basic support.

12985e5

Test / XSL in core tests had dependencies on services.

fd4c562

Test / Tentative fix

1299a9e

Test working locally but not on travis: ``` [ERROR] UrlAnalyzerTest.urlCheckerToSetStatus:250 expected:<12> but was:<6> ```

Popularity / Use updater instead of which does not need flush. Fix in…

3c822a1

…dex field name for popularity.

Use UTC when possible

8cc040b

Remove Joda time references

23286d8

Fix parsing string case with one or two milliseconds digits

9323854

Add missing code moved removed from MetadataUtils

f6a6042

Add code removed from MetadataUtils to XslUtils See commit a5a6cd7

juanluisrp and others added 4 commits December 9, 2020 11:14

Trim string to parse

2f2d1f6

Use Zulu time to index metadata

82682a9

Interpret the dates/ date-times appearing in the XML document as the timezone set in the settings if the string hasn't a explicit time offset.

Timezone support / SQL / Add migration.

923a4b1

Migrate existing date time columns to UTC timezone

f7df7fe

This commit adds a migration of the DateTime zones from the zone defined in system timezone setting to UTC in case the date in the database doesn't have a explicit timezone.

juanluisrp marked this pull request as ready for review December 16, 2020 15:21

juanluisrp requested review from fxprunayre and josegar74 December 16, 2020 15:21

Fix Source uuid type mapping

ef21d19

fxprunayre changed the title ~~Date handling Improvement~~ Add timezone support Dec 17, 2020

fxprunayre and others added 9 commits December 17, 2020 10:44

Migration / In case we can't parse existing dates, assign now.

c39b7ca

Migration / Keep this as an example. But timezone migration is handle…

477023c

…d by Java task.

Timezone config and translations.

a927d42

Workflow / Add missing field required for search results.

d057788

CSW / GetDomain operation not implemented in ES.

1931ac0

History / Do not fail on unknown user (which should not happen).

eeb10a5

Serialize dateAndTime property to JSON

6933735

Merge branch '4.0.x' into remove-joda-time

8c4167d

Fix bad merge.

729afd2

fxprunayre approved these changes Dec 18, 2020

View reviewed changes

fxprunayre merged commit 1e32d67 into 4.0.x Dec 18, 2020

fxprunayre deleted the remove-joda-time branch January 8, 2021 11:59

fxprunayre mentioned this pull request Oct 10, 2022

Record view / Invalid timezone shift for years outside moment's 10 years range #6606

Closed

oalbers mentioned this pull request Oct 16, 2024

Inspire plugin no longer working in QGIS warrieka/inspireNL#10

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add timezone support #5061

Add timezone support #5061

juanluisrp commented Sep 30, 2020 •

edited by fxprunayre

Loading

jodygarnett commented Sep 30, 2020 •

edited

Loading

juanluisrp commented Nov 30, 2020 •

edited

Loading

jodygarnett commented Dec 8, 2020

juanluisrp commented Dec 16, 2020

ianwallen commented Dec 16, 2020

juanluisrp commented Dec 17, 2020

ianwallen commented Feb 25, 2021

juanluisrp commented Feb 25, 2021

Add timezone support #5061

Add timezone support #5061

Conversation

juanluisrp commented Sep 30, 2020 • edited by fxprunayre Loading

jodygarnett commented Sep 30, 2020 • edited Loading

juanluisrp commented Nov 30, 2020 • edited Loading

jodygarnett commented Dec 8, 2020

juanluisrp commented Dec 16, 2020

ianwallen commented Dec 16, 2020

juanluisrp commented Dec 17, 2020

ianwallen commented Feb 25, 2021

juanluisrp commented Feb 25, 2021

juanluisrp commented Sep 30, 2020 •

edited by fxprunayre

Loading

jodygarnett commented Sep 30, 2020 •

edited

Loading

juanluisrp commented Nov 30, 2020 •

edited

Loading