Record view / Invalid timezone shift for years outside moment's 10 years range #6606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ars range Moment is included for a 10 years timezone range https://momentjs.com/timezone/docs/ so dates outside this range are not correctly displayed. eg. 2014-10-05 is displayed as 2014-10-04 when timezone is CET. ```xml <gmd:date> <gmd:CI_Date> <gmd:date> <gco:Date>2005-04-08</gco:Date> </gmd:date> <gmd:dateType> <gmd:CI_DateTypeCode codeList="http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#CI_DateTypeCode" codeListValue="creation"/> </gmd:dateType> </gmd:CI_Date> </gmd:date> <gmd:date> <gmd:CI_Date> <gmd:date> <gco:Date>2022-10-05</gco:Date> </gmd:date> <gmd:dateType> <gmd:CI_DateTypeCode codeList="http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#CI_DateTypeCode" codeListValue="publication"/> </gmd:dateType> </gmd:CI_Date> </gmd:date> <gmd:date> <gmd:CI_Date> <gmd:date> <gco:Date>2015-10-05</gco:Date> </gmd:date> <gmd:dateType> <gmd:CI_DateTypeCode codeList="http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#CI_DateTypeCode" codeListValue="revision"/> </gmd:dateType> </gmd:CI_Date> </gmd:date> <gmd:date> <gmd:CI_Date> <gmd:date> <gco:Date>2014-10-05</gco:Date> </gmd:date> <gmd:dateType> <gmd:CI_DateTypeCode codeList="http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#CI_DateTypeCode" codeListValue="revision"/> </gmd:dateType> </gmd:CI_Date> </gmd:date> <gmd:date> <gmd:CI_Date> <gmd:date> <gco:Date>2014-10-05</gco:Date> </gmd:date> <gmd:dateType> <gmd:CI_DateTypeCode codeList="http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#CI_DateTypeCode" codeListValue="revision"/> </gmd:dateType> </gmd:CI_Date> </gmd:date> <gmd:date> <gmd:CI_Date> <gmd:date> <gco:DateTime>2014-10-05T12:00:00+02:00</gco:DateTime> </gmd:date> <gmd:dateType> <gmd:CI_DateTypeCode codeList="http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#CI_DateTypeCode" codeListValue="revision"/> </gmd:dateType> </gmd:CI_Date> </gmd:date> ``` 2 options to fix this a) Load all data https://momentjs.com/timezone/ and not only 10 years range - bigger JS pack b) As timezone rules may change over time, only offset time according to nowaday rule. This applies b).
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moment is included for a 10 years timezone range https://momentjs.com/timezone/docs/ so dates outside this range are not correctly displayed. eg. 2014-10-05 is displayed as 2014-10-04 when timezone is CET.
2 options to fix this
a) Load all data https://momentjs.com/timezone/ and not only 10 years range - bigger JS pack
b) As timezone rules may change over time, only offset time according to nowaday rule.
This applies b). @juanluisrp what do you think is better ?
Related to #5061