Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve missing ch4 emissions error message #2039

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Nov 16, 2023

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR simply updates the error message printed when surface CH4 emissions are not found. It is expanded to tell uses to change the time cycle flag in HEMCO_Config.rc from RY to CY to use the most recently available year. This is useful if running a GC-Classic simulation for years after 2020 since the model will crash with this error unless the emissions are modified.

Expected changes

This is a no diff update.

Reference(s)

None

Related Github Issue(s)

None

@lizziel lizziel requested a review from yantosca November 16, 2023 21:26
@msulprizio msulprizio added the no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations label Nov 17, 2023
@msulprizio msulprizio added this to the 14.2.3 milestone Nov 17, 2023
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple PR that updates an error mesage. Good to merge.

CHANGELOG.md
- Add note about how the error message for missing surface CH4
  emissions now contains instructions on how to resolve the issue

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca added the category: Bug Fix Fixes a previously-reported bug label Nov 20, 2023
@yantosca
Copy link
Contributor

All GEOS-Chem Classic integration tests (except TOMAS) passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #f5b5694 Merge branch 'docs/dev' into dev/14.2.2
GEOS-Chem #382f11dca Merge PR #2040 (Lower GCHP timestep threshold if > C180)
HEMCO     #6ab11ea Merge PR #245 (Rename HEMCO_Config.rc.sample to HEMCO_Config.rc)

Using 24 OpenMP threads
Number of execution tests: 27

Submitted as SLURM job: 10285010
==============================================================================

Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 25
Execution tests failed: 2                # <==== TOMAS15 and TOMAS40
Execution tests not yet completed: 0

All GEOS-Chem Classic integration tests were zero-diff w/r/t 14.2.2, except TOMAS (failed), APM (parallelization issues) and RRTMG (parallelization issue in diagnostic output).

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

gchp      #074494e GEOS-Chem submodule update: Merge PR #2009 fixing links to RTD
GEOS-Chem #382f11dca Merge PR #2040 (Lower GCHP timestep threshold if > C180)
HEMCO     #6ab11ea Merge PR #245 (Rename HEMCO_Config.rc.sample to HEMCO_Config.rc)

Number of execution tests: 5

Submitted as SLURM job: 10285450
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

All GCHP integration tests were also zero-diff w/r/t 14.2.2.

@yantosca yantosca merged commit ed1a20e into dev/no-diff-to-benchmark Nov 20, 2023
@yantosca yantosca deleted the feature/improve_missing_CH4_emissions_error_message branch November 20, 2023 21:45
yantosca added a commit that referenced this pull request Dec 1, 2023
This is the official release of GEOS-Chem (science codebase) 14.2.3.
Updates include:

- Use integer flags to denote species units instead of strings (PR #1796)
- Prevent POAEMISS variable from being assigned if not allocated (PR #1987)
- Add an --no-bootstrap option to integration tests (PR #1990)
- Fixed incorrect comments on static H2O option (PR #2013)
- Improve missing CH4 emissions error message (PR #2039)
- Lower GCHP timestep threshold if > C180 rather than >= C180 (PR #2040)
- Add fixes to HEMCO_Config.rc for CH4, carbon simulations (PR #2042)
- Fix typos written to GCHP integration test log files (PR #2043)
- Update GCClassic rundir scripts to read restat file paths
  from download_data.yml (PR #2050)

Signed-off-by: Bob Yantosca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a previously-reported bug no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants