Add fixes to HEMCO_Config.rc for CH4 and carbon simulations #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HEMCO only supports use of .or. and .not. in the logical brackets within HEMCO_Config.rc. The use of .and. has been removed and replaced with separate open and close brackets to correctly handle the logic. Signed-off-by: Melissa Sulprizio <[email protected]>
…O_Config.rc for CH4/carbon simulations @laestrada Found that runs crash when setting EMISSIONS to false at the top of HEMCO_Config.rc because the OH_pert_factor used by the GLOBAL_OH field was included within the (((EMISSIONS ... )))EMISSIONS brackets. Moving the (((EMISSIONS line to after the OH_pert_factor entry resolves the issue ensuring that OH_pert_factor is always defined. Signed-off-by: Melissa Sulprizio <[email protected]>
…type METDIR is not used in the primary HEMCO_Config.rc file for all simulations. It is however used in the HEMCO_Config.rc.gmao_metfields and HEMCO_Config.rc.gcap2_metfields files where METDIR is defined again. This could lead to errors if there were inconsistencies between the two METDIR definitions. For instance, if users modified the resolution, domain, or met field type in the HEMCO_Config.rc.*metfields file and not in the primary HEMCO_Config.rc file then HEMCO would crash because of it would use the incorrect METDIR path. This is resolved by removing the redundant definition in the primary HEMCO_Config.rc files and just defining it in HEMCO_Config.rc.*metfields where it is actually used. This update also allows us to remove METDIR from the GCHP HEMCO_Config.rc files where it is not used because met fields defined in ExtData.rc and read in by MAPL, not HEMCO. Signed-off-by: Melissa Sulprizio <[email protected]>
msulprizio
added
no-diff-to-benchmark
yantosca
approved these changes
Nov 20, 2023
|
@msulprizio: GEOS-Chem Classic CH4 and carbon Integration tests are failing with: HEMCO ERROR: Cannot find field GHGI_OIL_EXP_SF. Please check variable name in the config. file
HEMCO ERROR: Error encountered in routine HCOIO_Read!
HEMCO ERROR: Error in HCOIO_DATAREAD called from HEMCO ReadList_Fill: GHGI_OIL_EXP_SF
--> LOCATION: ReadList_Fill (HCO_ReadList_Mod.F90)Maybe still some config file issues. I can take a look. |
That's strange. My integration tests on this branch all passed, except for TOMAS14 and TOMAS40 (known issue). I can help look into it. |
|
I know what the issue is. I forgot to mention you need to incorporate HEMCO PR #248 prior to merging this fix. The error you are receiving above is because the variable name in the netCDF file is too long for HEMCO to handle, but the HEMCO PR fixes that. |
|
Oops! I forgot to check out the dev/no-diff-to-benchmark branch in HEMCO. That'll fix it. Stay tuned for a rerun, thanks @msulprizio. |
This was referenced Nov 21, 2023
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #074494e GEOS-Chem submodule update: Merge PR #2009 fixing links to RTD
GEOS-Chem #78c1b7dc3 Merge PR #2042 (Fix HEMCO_Config.rc for CH4 and carbon simulations)
HEMCO #6ab11ea Merge PR #245 (Rename HEMCO_Config.rc.sample to HEMCO_Config.rc)
Number of execution tests: 5
Submitted as SLURM job: 10401258
==============================================================================All GCHP integration tests were identical w/r/t 14.2.2. |
|
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #f5b5694 Merge branch 'docs/dev' into dev/14.2.2
GEOS-Chem #78c1b7dc3 Merge PR #2042 (Fix HEMCO_Config.rc for CH4 and carbon simulations)
HEMCO #6ab11ea Merge PR #245 (Rename HEMCO_Config.rc.sample to HEMCO_Config.rc)
Using 24 OpenMP threads
Number of execution tests: 27
Submitted as SLURM job: 10362106
==============================================================================All tests except the following were identical to 14.2.2:
|
4 tasks
yantosca
added a commit
that referenced
this pull request
Dec 1, 2023
This is the official release of GEOS-Chem (science codebase) 14.2.3. Updates include: - Use integer flags to denote species units instead of strings (PR #1796) - Prevent POAEMISS variable from being assigned if not allocated (PR #1987) - Add an --no-bootstrap option to integration tests (PR #1990) - Fixed incorrect comments on static H2O option (PR #2013) - Improve missing CH4 emissions error message (PR #2039) - Lower GCHP timestep threshold if > C180 rather than >= C180 (PR #2040) - Add fixes to HEMCO_Config.rc for CH4, carbon simulations (PR #2042) - Fix typos written to GCHP integration test log files (PR #2043) - Update GCClassic rundir scripts to read restat file paths from download_data.yml (PR #2050) Signed-off-by: Bob Yantosca <[email protected]>
msulprizio
added
the
topic: Carbon Gases Simulations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard / GCST
Describe the update
This pull request includes the following fixes:
.and.from HEMCO_Config.rc files because it is not actually supported by HEMCO. This addresses issue #2036.OH_pert_factorentry outside ofEMISSIONSlogical in HEMCO_Config.rc to ensure it is always defined and applied to the OH fields.METDIRfrom HEMCO_Config.rc files for simulations types and solely use definition from the HEMCO_Config.rc.*metfields file.Expected changes
Fixes 1 and 2 above will will only impact the carbon and CH4 simulations, while fix 3 is a zero-diff change.
Reference(s)
If this is a science update, please provide a literature citation.
Related Github Issue(s)
Closes #2036