Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect .normalize_pkg due to incomplete bioc data #69

Closed
chainsawriot opened this issue Feb 23, 2023 · 3 comments
Closed

Incorrect .normalize_pkg due to incomplete bioc data #69

chainsawriot opened this issue Feb 23, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@chainsawriot
Copy link
Collaborator

chainsawriot commented Feb 23, 2023

Ref #58

.normalize_pkg("affydata", "3.3")

returns "cran::affydata" which is not correct.

The gist is that our current .memo_search_bioc() only returns Software from the view, not "AnnotationData", "ExperimentData" and "Workflow".

nrow(.memo_search_bioc("3.3")) ##1211
@chainsawriot
Copy link
Collaborator Author

There is also "book". But let's ignore it for now.

@chainsawriot chainsawriot changed the title Incorrect .normalize_pkgref due to incomplete bioc data Incorrect .normalize_pkg due to incomplete bioc data Feb 23, 2023
@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Feb 23, 2023

The simplest solution right now is to use vctrs::vec_rbind() (my original solution used dplyr::bind_rows()). It also introduces cli and glue.

Maybe we can make use of cli (e.g. display of the S3) and glue (e.g. replace some of the tedious paste())

chainsawriot added a commit that referenced this issue Feb 23, 2023
chainsawriot added a commit that referenced this issue Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant