Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Improve AppMap service stop/restart #496

Closed
wants to merge 3 commits into from

Conversation

jansorg
Copy link
Collaborator

@jansorg jansorg commented Nov 8, 2023

#411

  • Ensure that stop() does not trigger a restart
  • Implement exponential back-off with a reset of restart attempts after some time

@jansorg jansorg marked this pull request as draft November 8, 2023 14:44
Copy link

github-actions bot commented Nov 8, 2023

AppMap runtime code review

Summary Status
Failed tests ✅ All tests passed
API changes 🔧 1 non-breaking
Security flaws ✅ None detected
Performance problems ✅ None detected
Code anti-patterns ✅ None detected
New AppMaps 0️⃣ No new AppMaps

🔄 API changes

🔧 Non-breaking changes

These changes are backwards-compatible, according to the OpenAPI specification.

  • Add path /api/appmaps/create_upload
Detailed OpenAPI diff
--- base/openapi.yml	2023-11-05 00:04:42.000000000 +0000
+++ head/openapi.yml	2023-11-08 14:53:54.000000000 +0000
@@ -1,7 +1,5 @@
 # This document can be generated with the following command: 
-# npx @appland/appmap@latest openapi
-#
-# NOTE: You will need Node.js installed on your machine to run the above command
+#   appmap openapi
 #
 # Some helpful options:
 #   --output-file        output file name
@@ -9,7 +7,7 @@
 #   --openapi-version    version field of the OpenAPI document
 #
 # For more info, run:
-# npx @appland/appmap@latest openapi --help
+#   appmap openapi --help
 #
 # Visit our docs: https://appmap.io/docs/openapi.html
 #
@@ -17,6 +15,12 @@
 info:
   title: My project
   version: v1
-paths: {}
+paths:
+  /api/appmaps/create_upload:
+    post:
+      responses:
+        '200':
+          content: {}
+          description: OK
 components: {}

@jansorg jansorg closed this Nov 15, 2023
@jansorg jansorg deleted the jansorg/process-termination branch November 15, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant