Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog title and positive button not visible in Dark Theme #2801

Closed
ravi-kishan opened this issue Jan 16, 2019 · 3 comments
Closed

Dialog title and positive button not visible in Dark Theme #2801

ravi-kishan opened this issue Jan 16, 2019 · 3 comments
Assignees
@ravi-kishan
Labels
bug in progress

Comments

@ravi-kishan
Copy link
Contributor

Software and hardware versions

Collect v1.17.1, Android v7.0 API 24, Motorola Moto G4

Problem description

The title and positive button of the showAdditionalExplanation dialog are not visible in Dark Theme in preference activity. The dialog works correctly in other activities.

Steps to reproduce the problem

Goto General Settings->User Interface and select Dark Theme
Then goto General Settings -> Server -> Choose Google Drive in Type
Select Google Account ->Deny Contacts permission

Or any other way to see showAdditionalExplanation Dialog in preferences activity.

Expected behavior

The title and positive button should be visible

Other information

odk
@ravi-kishan
Copy link
Contributor Author

@grzesiek2010 May I work on this issue?

@grzesiek2010
Copy link
Member

sure you can claim any not claimed issue. To do that please add a comment:

@opendatakit-bot claim

@grzesiek2010 grzesiek2010 removed their assignment Jan 16, 2019
@ravi-kishan
Copy link
Contributor Author

@opendatakit-bot claim

ravi-kishan added a commit to ravi-kishan/collect that referenced this issue Jan 16, 2019
@ravi-kishan
Removed setting textColor to primaryTextColor. Fix getodk#2801
bde1c1e
@ravi-kishan ravi-kishan mentioned this issue Jan 17, 2019
Merged
3 tasks
grzesiek2010 pushed a commit that referenced this issue Feb 6, 2019
@ravi-kishan @grzesiek2010
Removed setting textColor to primaryTextColor. Fix #2801 (#2802)
1ba18d4 
* Removed setting textColor to primaryTextColor. Fix #2801

* Did same thing for light theme

* Undo unintended change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravi-kishan ravi-kishan

Labels
bug in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grzesiek2010 @getodk-bot @ravi-kishan