Removed setting textColor to primaryTextColor. Fix #2801

[ravi-kishan]

Closes #2801

What has been done to verify that this works as intended?

Manually tested the showAdditionalExplanation dialog. It is working fine.

Why is this the best possible solution? Were any other approaches considered?

This solution works without changing the theme of the dialog.
Other solution would be to change the theme of dialog to dark theme when app is in dark theme.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Intentional changes-The dialog title and positive button are visible.
Unintentional changes - The positive button texts of all dialogs have become green from white in dark theme.

Do we need any specific form for testing your changes? If so, please attach one.

No

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No

Before submitting this PR, please make sure you have:

• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[grzesiek2010]

@ravi-kishan

It looks as if android:textColor in AppTheme.SettingsTheme.Light is also redundant, right? Could you get rid of it as well to keep consistency?

[ravi-kishan]

@grzesiek2010
The code is not redundant.The following effect occurs.
Before removing

After removing

The code is changing default green colour to black or white. The positive button of dialog is not visible
in dark theme because it is hardcoded to use light theme everytime.So the dialog and text are both white.

Shall i remove the android:textColor code or make dialog use dark theme when app is in dark theme mode?

[grzesiek2010]

You can just remove it.

or make dialog use dark theme when app is in dark theme mode?

we decided to keep that dialog white for consistency - the first one is also white, so we don't want to change it.

[kkrawczyk123]

Tested with success!
Verified on Androids: 6.0, 7.0 and 8.1.

@opendatakit-bot unlabel "needs testing"
@opendatakit-bot label "behavior verified"

[grzesiek2010]

Thank @ravi-kishan