Respect short label forms #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
reviewed
May 11, 2018
| @@ -398,4 +398,14 @@ public void onClick(DialogInterface dialog, int i) { | |||
| alertDialog.setButton(getString(R.string.ok), errorListener); | |||
| alertDialog.show(); | |||
| } | |||
|
|
|||
| private String getLabel(FormEntryPrompt formEntryPrompt) { | |||
There was a problem hiding this comment.
You shouldn't need this one -- FormEntryPrompt extends FormEntryCaption.
There was a problem hiding this comment.
Right, thanks, it's fixed
grzesiek2010
force-pushed
the
COLLECT-1401
branch
from
2a2d84c to
d833a67
Compare
lognaturel
approved these changes
May 14, 2018
|
Tested with success! Verified on Android 4.1, 4.2, 4.4, 5.1, 6.0, 8.1
@opendatakit-bot label "behavior verified" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1401
What has been done to verify that this works as intended?
I tested the attached form.
Why is this the best possible solution? Were any other approaches considered?
Are there any risks to merging this code? If so, what are they?
No.
Do we need any specific form for testing your changes? If so, please attach one.
ShorLabel.xml.txt
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Hmmm I'm not sure...
Before submitting this PR, please make sure you have:
./gradlew pmd checkstyle lint findbugsand confirmed all checks still pass.