Clear the list if reading files canceled #2970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2959 #2977
What has been done to verify that this works as intended?
I tested canceling the task during reading files from GD.
Why is this the best possible solution? Were any other approaches considered?
@mmarciniak90 I was thinking about this issue. Initially, I agreed that
refresh
button would be good here as described in the issue but now I think that having not fully downloaded list of files and displaying sucha a list is misleading and might cause some strange exceptions in the future.I think the easiest way to improve the current approach is clearing the list if a user cancels the task. Then a user can use
My Drive/Shared with me
buttons to read files again. I know that if he is deep in hierarchy of dirs it takes him to the main level but it's safer at least.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It's a small not risky change. testing canceling the task would be enough here.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.