Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the list if reading files canceled #2970

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Mar 27, 2019

Closes #2959 #2977

What has been done to verify that this works as intended?

I tested canceling the task during reading files from GD.

Why is this the best possible solution? Were any other approaches considered?

@mmarciniak90 I was thinking about this issue. Initially, I agreed that refresh button would be good here as described in the issue but now I think that having not fully downloaded list of files and displaying sucha a list is misleading and might cause some strange exceptions in the future.
I think the easiest way to improve the current approach is clearing the list if a user cancels the task. Then a user can use My Drive/Shared with me buttons to read files again. I know that if he is deep in hierarchy of dirs it takes him to the main level but it's safer at least.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It's a small not risky change. testing canceling the task would be enough here.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 changed the title Clear list if reading files canceled Clear the list if reading files canceled Mar 28, 2019
@kkrawczyk123
Copy link
Contributor

Tested with success!!
Verified on Androids: 4.2, 4.4, 5.1, 6.0 and 8.1

@opendatakit-bot unlabel "needs testing"
@opendatakit-bot label "behavior verified"

@lognaturel lognaturel merged commit cde5af1 into getodk:master Apr 1, 2019
@grzesiek2010 grzesiek2010 added this to the v1.21 milestone Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants