keyvault: update keyvault to use release/v1 secret protocol

[VinozzZ]

This PR does three things:

• updates keyvault plugin to use the latest secret plugin protocol from porter.
• updates magefile to reference the new getporter.sh/magefile repo
• removes storage plugins, blob and table stores, from this repo

This PR closes #40

[carolynvs]

@VinozzZ Would you please fill out the PR with a description of the change and link to the relevant issue?

[carolynvs]

One way to get some tests, even if they aren't part of CI would be to have a bash script that you could execute before checking in that would validate a few scenarios, and use the az cli to check that the values were persisted properly.

[carolynvs]

Can you update the readme to make it clear that the vault in the secrets config is also written to by porter?

[carolynvs]

I received the following error when I ran the script:

$ ./tests/integration/script.sh carolynvs
remote: Enumerating objects: 28196, done.
remote: Counting objects: 100% (833/833), done.
remote: Compressing objects: 100% (612/612), done.
remote: Total 28196 (delta 375), reused 476 (delta 209), pack-reused 27363
Receiving objects: 100% (28196/28196), 34.61 MiB | 60.68 MiB/s, done.
Resolving deltas: 100% (16262/16262), done.
From https://github.com/getporter/porter
 * [new branch]        release/v1 -> origin/release/v1
fatal: invalid reference: release/v1
EXIT STATUS: 128
cleaned up test successfully

Instead of implementing here in a script installing porter, you can use the https://github.com/getporter/magefiles target porter.EnsurePorter. How about you add a target called TestIntegration and have it depend on EnsurePorter. Then it can call the bash script here.

[VinozzZ]

From my understanding, the EnsurePorter only works for published release versions? In this case, the test would fail since the new secret protocol is not in a release yet.
What's your git version?

[carolynvs]

I'm on 2.32

[VinozzZ]

I changed the reference to use the remote branch. Let me know if it still causes trouble for u

[carolynvs]

The script is expecting me to set PORTER_HOME and when I set that to $PWD/bin it complains that it's not a working tree. Is this supposed to be the path to the porter repository or something that is set internally in the script and not by me?

[VinozzZ]

That's odd. What error do you get that prompt you to set PORTER_HOME manually? It should do that automatically by the script

[carolynvs]

I finally got it to work by setting export PORTER_HOME='. Maybe just remove the set -u flag, or move up the declaration of PORTER_HOME above cleanup?

[carolynvs]

Thanks for updating the plugin to work with the new changes!