Bump secrets plugin protocol version to 2 #2077
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Version 1 is the old protocol that only supported Resolve.
Version 2 is the new protocol with gRPC, context.Context and the new Create function.
What issue does it fix
Part of #1027
Notes for the reviewer
We should reference the constant defined in Porter from the plugins so that when the plugin references porter to get the protocol interface they automatically get the correct version of the protocol.
getporter/azure-plugins#41
getporter/kubernetes-plugins#108
Checklist
Reviewer Checklist