Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump secrets plugin protocol version to 2 #2077

Merged

Conversation

carolynvs
Copy link
Member

What does this change

Version 1 is the old protocol that only supported Resolve.
Version 2 is the new protocol with gRPC, context.Context and the new Create function.

What issue does it fix

Part of #1027

Notes for the reviewer

We should reference the constant defined in Porter from the plugins so that when the plugin references porter to get the protocol interface they automatically get the correct version of the protocol.

getporter/azure-plugins#41
getporter/kubernetes-plugins#108

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Version 1 is the old protocol that only supported Resolve.
Version 2 is the new protocol with gRPC, context.Context and the new
Create function.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs marked this pull request as ready for review May 18, 2022 21:51
@carolynvs carolynvs requested a review from VinozzZ May 18, 2022 21:51
@carolynvs carolynvs merged commit efc68ef into getporter:release/v1 May 19, 2022
@carolynvs carolynvs deleted the bump-secrets-protocol-version branch May 19, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants