-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move database initialization overhead into an init function #1782
Labels
Comments
carolynvs
added a commit
to carolynvs/porter
that referenced
this issue
Sep 28, 2021
* Consolidate creating indices into just 3 calls. We can further refine this in getporter#1782, when we make initializing the db a single event. * Do not ping on connect. This does mean that the first query will be slower as it will establish the connection. So let's be aware of that and not assume the first call just has horrible performance. I am still looking into why the first call that establishes the connection has bad performance. Signed-off-by: Carolyn Van Slyck <[email protected]>
3 tasks
carolynvs
added a commit
to carolynvs/porter
that referenced
this issue
Oct 1, 2021
* Consolidate creating indices into just 3 calls. We can further refine this in getporter#1782, when we make initializing the db a single event. * Do not ping on connect. This does mean that the first query will be slower as it will establish the connection. So let's be aware of that and not assume the first call just has horrible performance. I am still looking into why the first call that establishes the connection has bad performance. Signed-off-by: Carolyn Van Slyck <[email protected]>
Don't forget to repeat the cosmosdb performance tests to verify that this brings performance back to acceptable levels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
There are activities that we run on every CLI command, that are not zero cost:
We could keep a file in PORTER_HOME that indicates if these tasks have been performed for the current storage configuration (hashed so that if the config changes, we repeat the check), and lets us only do this setup once per storage backend. This would save us 4 db calls per CLI command, which depending on the connection speed is ~1-2 seconds.
This change should be made on the v1 branch.
The text was updated successfully, but these errors were encountered: