Reduce how often we hit the database #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the test, those seem to be flakes that are only failing on CI. I assume my dev machine is beefy enough that's why I'm getting different (better) timings. I'll flail about on this with CI until it passes consistently! |
* Consolidate creating indices into just 3 calls. We can further refine this in getporter#1782, when we make initializing the db a single event. * Do not ping on connect. This does mean that the first query will be slower as it will establish the connection. So let's be aware of that and not assume the first call just has horrible performance. I am still looking into why the first call that establishes the connection has bad performance. Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
When we set pkg.Version in a test, it should not run in parallel and should reset changes to those global variables when complete. Signed-off-by: Carolyn Van Slyck <[email protected]>
|
Yay! Fixed some test timeouts and we are good to go. 💨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
I am still looking into why the first call that establishes the connection has bad performance. https://www.mongodb.com/community/forums/t/establishing-a-connection-is-slow/125826
What issue does it fix
I was creating each index in its own call but there's actually a different function on the mongodb client that I can use to batch those calls up to improve performance.
Notes for the reviewer
NA
Checklist