Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs 1845: Add H1 anchor links #1847

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

mikebarkas
Copy link
Contributor

@mikebarkas mikebarkas commented Jan 5, 2022

What does this change

This adds CSS H1:hover to show the anchor link icon for H1 headings.
This also adds scroll-margin-top to H1 and H2 so the headings are
not hidden under the top menu bar.

What issue does it fix

Closes #1845

Notes for the reviewer

I included screenshots of the changes in issue #1845

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

This adds CSS H1:hover to show the anchor link icon for H1 headings.
This also adds scroll-margin-top to H1 and H2 so the headings are
not hidden under the top menu bar.

Signed-off-by: Mike Barkas <[email protected]>
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are a lifesaver! This is working better than before even, I wasn't sure how to fix that the header was being scrolled past. 🙇‍♀️

@carolynvs carolynvs merged commit 1342c0c into getporter:main Jan 5, 2022
carolynvs added a commit to carolynvs/porter that referenced this pull request Feb 7, 2022
* Merge pull request getporter#1884 from carolynvs/blog-secret
* Merge pull request getporter#1891 from carolynvs/survey
* Blog: IgnoreErrors and Az group command (getporter#1854)
* Merge pull request getporter#1871 from carolynvs/heading-spa
* Merge pull request getporter#1861 from carolynvs/pr-checklis
* Merge pull request getporter#1850 from carolynvs/link-v1-doc
* Merge pull request getporter#1847 from mikebarkas/1845--anch
* 1757  completion command (getporter#1844)
* Merge pull request getporter#1839 from carolynvs/status-badg
* docs: 1841 Fix typo and align template divs (getporter#1842)

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs mentioned this pull request Feb 7, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heading links in the docs are missing
2 participants