Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link v1 docs from main site #1850

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Jan 6, 2022

What does this change

Makes it easier for people to know which version of the docs they are on (v0.38 or v1.0.0) and switch between the two. Long term, a better strategy for versioning the docs site would be great but this is a small change that we can do right now.

https://deploy-preview-1850--porter.netlify.app/docs/

What issue does it fix

N/A

Notes for the reviewer

This PR has a buddy: See #1849.

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

Makes it easier for people to know which version of the docs they are on (v0.38 or v1.0.0) and switch between the two. Long term, a better strategy for versioning the docs site would be great but this is a small change that we can do right now.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs
Copy link
Member Author

screenshot

The docs nav highlights that we are on the v0.38 (stable) release, and links to the v1 docs site.

Browser metadata
Path:      /docs/
Browser:   Firefox 92.0 on Mac OS 10.15
Viewport:  1440 x 677 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@carolynvs carolynvs changed the title Link v1 docs Link v1 docs from main site Jan 6, 2022
@carolynvs carolynvs marked this pull request as ready for review January 6, 2022 15:47
@carolynvs carolynvs requested a review from iennae January 6, 2022 15:47
@carolynvs carolynvs merged commit 9079eaa into getporter:main Jan 7, 2022
@carolynvs carolynvs deleted the link-v1-docs branch January 7, 2022 14:54
carolynvs added a commit to carolynvs/porter that referenced this pull request Feb 7, 2022
* Merge pull request getporter#1884 from carolynvs/blog-secret
* Merge pull request getporter#1891 from carolynvs/survey
* Blog: IgnoreErrors and Az group command (getporter#1854)
* Merge pull request getporter#1871 from carolynvs/heading-spa
* Merge pull request getporter#1861 from carolynvs/pr-checklis
* Merge pull request getporter#1850 from carolynvs/link-v1-doc
* Merge pull request getporter#1847 from mikebarkas/1845--anch
* 1757  completion command (getporter#1844)
* Merge pull request getporter#1839 from carolynvs/status-badg
* docs: 1841 Fix typo and align template divs (getporter#1842)

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs mentioned this pull request Feb 7, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants