-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add upm target #209
feat: Add upm target #209
Conversation
I see this is a Draft, but just a few things not to forget about:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, maybe drop the draft tag?
Added the lint automation and fixes here: #214 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these relative imports will fix the test issues. I'll look into why this is breaking separately.
Btw is it possible to have some tests for this target?
874e2ca
to
3004e1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just proofreading. (You can take the girl out of copyediting...) Otherwise LGTM!
Co-authored-by: Katie Byers <[email protected]>
Co-authored-by: Katie Byers <[email protected]>
Co-authored-by: Katie Byers <[email protected]>
Thanks a lot @BYK , @bitsandfoxes , @tonyo , @lobsterkatie !!! 🥳 🥳 |
Unity SDK works in two repositories:
https://github.com/getsentry/sentry-unity <- SDK
https://github.com/getsentry/unity <- release repo for the user
Unity users add our package by providing a git URL to their package manager. Versioning and potential rollbacks for them are made available via tags (i.e. https://github.com/getsentry/unity.git#x.x.x).
Release steps: