Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Reinstate linting and make it automatic #214

Merged
merged 16 commits into from
May 3, 2021
Merged

ci: Reinstate linting and make it automatic #214

merged 16 commits into from
May 3, 2021

Conversation

BYK
Copy link
Member

@BYK BYK commented May 3, 2021

No description provided.

@BYK BYK requested review from chadwhitacre, jan-auer and tonyo May 3, 2021 07:46
@BYK BYK closed this May 3, 2021
@BYK BYK reopened this May 3, 2021
@BYK BYK mentioned this pull request May 3, 2021
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally speaking, it's unfortunate that it adds these parentheses, but I also understand the reasoning.

Please merge master and rerun the formatter to resolve conflicts.

README.md Outdated
- Configure additional options (changelog management policy, tag prefix, etc.)

- List there all the targets you want to publish to
- Configure additional options (changelog management policy, tag prefix, etc.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unintended.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, let me see how I can fix this.

package.json Outdated Show resolved Hide resolved
@jan-auer jan-auer changed the title ci: Reinstate lintin and make it automatic ci: Reinstate linting and make it automatic May 3, 2021
@BYK BYK enabled auto-merge (squash) May 3, 2021 12:59
@BYK BYK merged commit 6fdce47 into master May 3, 2021
@BYK BYK deleted the byk/ci/lint branch May 3, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants