This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 102
Add example for AWS Lambda & Serverless Framework #101
Merged
kamilogorek
merged 5 commits into
getsentry:master
from
connorads:add-example-serverless-framework-aws-lambda
Aug 17, 2021
Merged
Add example for AWS Lambda & Serverless Framework #101
kamilogorek
merged 5 commits into
getsentry:master
from
connorads:add-example-serverless-framework-aws-lambda
Aug 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Feel free to merge it @ahmedetefy if you also +1
ahmedetefy
suggested changes
Jul 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @connorads
Thanks for opening the PR. The Serverless examples look good
However, rather than changing the directory stucture, I think it makes more sense to just add a serverless-framework
directory to the following path aws-lambda/node
for Node that contains your Serverless example, and well the same for Python as well!
Hey @ahmedetefy, let me know what you think of the new structure |
Hey @ahmedetefy, we good to merge this now? |
connorads
commented
Aug 12, 2021
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add a examples of integrating Sentry with AWS Lambda in Node and Python with Lambda Layers using Serverless Framework.
Follow up from getsentry/sentry-docs#3830
Wasn't really sure how much detail to add with the README/docs and wasn't sure about the folder structure.
Feedback and changes welcome 🤗
Testing
Node
Python
Sentry