Skip to content
This repository has been archived by the owner on Dec 5, 2023. It is now read-only.

Add example for AWS Lambda & Serverless Framework #101

Conversation

connorads
Copy link
Contributor

This is to add a examples of integrating Sentry with AWS Lambda in Node and Python with Lambda Layers using Serverless Framework.

Follow up from getsentry/sentry-docs#3830

Wasn't really sure how much detail to add with the README/docs and wasn't sure about the folder structure.
Feedback and changes welcome 🤗

Testing

Node

image

Python

image

Sentry

image

Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge it @ahmedetefy if you also +1

Copy link

@ahmedetefy ahmedetefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @connorads

Thanks for opening the PR. The Serverless examples look good

However, rather than changing the directory stucture, I think it makes more sense to just add a serverless-framework directory to the following path aws-lambda/node for Node that contains your Serverless example, and well the same for Python as well!

@connorads
Copy link
Contributor Author

Hey @ahmedetefy, let me know what you think of the new structure

@connorads
Copy link
Contributor Author

Hey @ahmedetefy, we good to merge this now?

@kamilogorek kamilogorek merged commit 5089b00 into getsentry:master Aug 17, 2021
@kamilogorek
Copy link
Contributor

Thanks!

@connorads connorads deleted the add-example-serverless-framework-aws-lambda branch October 9, 2021 12:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants