feat(aws-lambda): Add Serverless Framework code snippet for Python #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/F51wC88oRWq36YHGafzduuYpxxHP |
imatwawana
requested review from
a team,
ahmedetefy and
vladanpaunovic
and removed request for
a team
|
This LGTM but maybe @PeloWriter or @imatwawana could help to make this an include as we have everywhere else. |
ahmedetefy
approved these changes
Jul 12, 2021
ahmedetefy
changed the title
connorads
commented
Jul 18, 2021
connorads
commented
Jul 19, 2021
|
Just resolved the merge conflicts 💃 Thanks @ahmedetefy for the changes and approval. |
|
Nothing further, thank you, @connorads. I'm tracking the suggestion to create |
PeloWriter
approved these changes
Jul 19, 2021
taylangocmen
pushed a commit
that referenced
this pull request
Jul 22, 2021
…3830) * Add Serverless Framework example for Python * Refactored aws lambda code snippets for better readability * Add missing functions conf + rename layersResource back to custom Co-authored-by: Ahmed Etefy <[email protected]>
|
I've now opened up a PR for some examples: getsentry/examples#101 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating docs for two reasons:
serverlessContext
Just tried to use
serverlesswith Python and the AWS Lambda Layer Integration.Got something working, with a bit of trial and error, by combining the docs from:
Preview
https://sentry-docs-git-fork-connorads-patch-1.sentry.dev/product/integrations/aws-lambda/#serverless-framework