feat(upload): Implement PDB and PE upload #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the upload of PE and PDB files.
sentry-clionly attempts the upload if thepdbscapability is returned by the chunk upload endpoint. Otherwise, it silently skips PDBs like before.If PDBs are selected for upload,
sentry-cliadditionally scans for PEs and remembers their age. Once all files have been compiled, the PDBs' age is fixed using the one from the PE. The PE files are only uploaded if they are selected and contain usable information (either a symbol table, or unwind info on x64 builds)See getsentry/sentry#13725