Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upload): Implement PDB and PE upload #13725

Merged
merged 5 commits into from
Jun 18, 2019
Merged

feat(upload): Implement PDB and PE upload #13725

merged 5 commits into from
Jun 18, 2019

Conversation

jan-auer
Copy link
Member

Allow to upload (native) PDBs and PE files via the chunk upload and store them as debug files. Additionally, this PR allows to override debug identifiers in the chunk upload.

For now, the override is only applied if the UUID portion of the id matches. This is used to fix the age of PDB files. All other overrides are discarded by the server.

There is a new chunk upload capability flag pdbs, which indicates the following:

  • The server accepts PDBs.
  • The server accepts debug_id overrides.
  • The server will ignore unknown properties in the chunk upload request.

@jan-auer jan-auer merged commit 296a423 into master Jun 18, 2019
@jan-auer jan-auer deleted the feat/pdb-upload branch June 18, 2019 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants