Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new fix to suggested WSGI config #1204

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Sep 6, 2019

This issue emerged in getsentry/sentry-php#857. We found the fix, and this will suggest it.

For reference:

When the enable_compression option was enabled it was affecting only the responses received by the server while first of all the requests should be compressed with GZIP. This PR fixes the problem. Note that if Sentry is running in uWSGI mode and behind a NGINX server as described in the documentation and the client sends a chunked request (as in our case) then a bug in the latter makes the proxied request have both the Transfer-Encoding and Content-Length headers set, which per HTTP/1.1 specs is not valid. For this reason Sentry will be unable to read the request content and will silently discard the event logging an error. The solution is to unset the Transfer-Encoding header in the NGINX config.

Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@dashed dashed merged commit bd1f173 into getsentry:master Sep 18, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants