Fix sending of GZIP-compressed requests when the enable_compression option is on #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
approved these changes
Jul 30, 2019
Jean85
approved these changes
Jul 30, 2019
HazAT
added a commit
that referenced
this pull request
Aug 22, 2019
* release/2.1.2: meta: Update changelog meta: Changelog 2.1.2 Skip integrations not bound to the current client and fetch their options from it (#861) Do not set the transaction attribute of the event when in CLI (#864) Added OXID eShop to the list of 3rd party integrations (#860) Fix error thrown when function name is missing in the stacktrace frame (#823) Fix sending of GZIP-compressed requests when the enable_compression option is on (#857) # Conflicts: # CHANGELOG.md # tests/ClientBuilderTest.php
Jean85
added a commit
to Jean85/sentry-docs
that referenced
this pull request
Sep 6, 2019
jan-auer
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Sep 23, 2019
* master: (22 commits) chore(proofreading): Remove pain (#1229) fix: Add note about complications in Django Channels (#1225) fix: Change the goroutine example order (#1226) swap compile for implementation in android gradle snippet feat: Sample for ASP.NETCore 3 (#1222) fix: Fix a broken link into Flask docs (#1224) change to using seconds as timeout measurement. feat: Added redirect for rollups feat: Added new grouping documentation (#1047) Mark two options as supported in the PHP SDK feat: Add ignore options docs for JS SDK (#1213) update URL snapshot review changes 1 Update javascript documentation link docs: [sentry-cli] Update strip-prefix description (#1214) (ref)React Native: Fix typo, code formatting, and format notes (#1215) Fix formatting of levels in PHP docs (#1209) Add new uwsgi_param in suggested WSGI config as suggested in getsentry/sentry-php#857 Make throttling/rate limiting docs more verbose #1193 Fix typo ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
enable_compressionoption was enabled it was affecting only the responses received by the server while first of all the requests should be compressed with GZIP. This PR fixes the problem. Note that if Sentry is running in uWSGI mode and behind a NGINX server as described in the documentation and the client sends a chunked request (as in our case) then a bug in the latter makes the proxied request have both theTransfer-EncodingandContent-Lengthheaders set, which per HTTP/1.1 specs is not valid. For this reason Sentry will be unable to read the request content and will silently discard the event logging an error. The solution is to unset theTransfer-Encodingheader in the NGINX config.ping @HazAT can you please update the docs with the note about NGINX + uWSGI?