Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native): enable debug-option by default in debug-build. #12470

Merged

Conversation

supervacuus
Copy link
Collaborator

@supervacuus supervacuus commented Jan 27, 2025

DESCRIBE YOUR PR

This updates the documentation for the debug option. The existing documentation was already slightly out of date and this also adds documentation for a new default when running on debug-build: getsentry/sentry-native#1128

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 11:29am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Jan 27, 2025 11:29am
develop-docs ⬜️ Ignored (Inspect) Jan 27, 2025 11:29am

Copy link

codecov bot commented Jan 27, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.61MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.3MB 6 bytes (-0.0%) ⬇️

@supervacuus supervacuus merged commit 2066d45 into master Jan 31, 2025
11 checks passed
@supervacuus supervacuus deleted the feat/native_default_debug_true_when_using_debug_build branch January 31, 2025 09:50
@supervacuus
Copy link
Collaborator Author

sentry-native 0.7.20 was just released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants