Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable debug-option by default in debug-build. #1128

Merged

Conversation

supervacuus
Copy link
Collaborator

fixes: #1121

The implementation allows users to set the environment variable SENTRY_DEBUG to 0 to override.

Copy link

github-actions bot commented Jan 27, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 350e608

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (3dc60ed) to head (350e608).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
- Coverage   82.69%   82.66%   -0.04%     
==========================================
  Files          53       53              
  Lines        7930     7930              
  Branches     1240     1240              
==========================================
- Hits         6558     6555       -3     
- Misses       1263     1264       +1     
- Partials      109      111       +2     

Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@supervacuus supervacuus merged commit 2aa4b16 into master Jan 27, 2025
25 checks passed
@supervacuus supervacuus deleted the feat/enable_debug_option_by_default_in_debug_builds branch January 27, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set options.debug = true if we can reliably detect that the app runs in a debug build
2 participants