feat: Add php max_request_body_size #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
suggested changes
Oct 17, 2019
| ##### max_request_body_size | ||
|
|
||
| This option represents the size limit in bytes beyond which the body of the request is not captured. Default value is `medium`. Possible values are `none` = never send body, `small`, `medium`, `alawys` = always send the body, no matter how large it is. | ||
| The values are chosen like this on purpose since the SDK internally can define what the exact limits are. |
There was a problem hiding this comment.
Still not sure what those values mean. Maybe add some ranges? or current values?
There was a problem hiding this comment.
I think this is an attempt to allow us to change this without 'breaking' customers.
Today you'd need to read the code to see what we consider small, medium etc.
i.e:
bruno-garcia
requested changes
Oct 17, 2019
Co-Authored-By: Kamil Ogórek <[email protected]>
kamilogorek
approved these changes
Oct 17, 2019
bruno-garcia
approved these changes
Oct 17, 2019
|
Merging so it won't get stuck. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.