Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add php max_request_body_size #1281

Merged
merged 2 commits into from
Oct 28, 2019
Merged

feat: Add php max_request_body_size #1281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63f9728
feat: Add php max_request_body_size
HazAT Oct 17, 2019
af7c3c5
Update src/collections/_documentation/platforms/php/index.md
HazAT Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/collections/_documentation/platforms/php/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,12 @@ The number of attempts that should be made to send an event before erroring
and dropping it from the queue.
By default this option is set to `6`.


##### max_request_body_size

This option represents the size limit in bytes beyond which the body of the request is not captured. The default value is `medium`. Possible values are `none` = never send body, `small`, `medium`, `always` = always send the body, no matter how large it is.
The values are chosen like this on purpose since the SDK internally can define what the exact limits are.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure what those values mean. Maybe add some ranges? or current values?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an attempt to allow us to change this without 'breaking' customers.
Today you'd need to read the code to see what we consider small, medium etc.
i.e:

https://github.com/getsentry/sentry-dotnet/blob/46bf5548d347ad1e206aefa3ea91cc46ab02004f/src/Sentry/Extensibility/RequestBodyExtractionDispatcher.cs#L45

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ this


### Transport

Sentry PHP is not tied to any specific library that sends HTTP messages. Instead,
Expand Down