You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maybe it's moe of a problem from Maven's end, but let's say you want to dockerize a project that is configured to upload Sentry source bundles, but you don't have a sentry Auth key or want to provide one during the image build, it would be nice to not have to mingle with the pom.xml configuration and simply be able to pass either an env variable or a property to disable the plugin.
Solution Brainstorm
Have the plugin check for an env-variable and/or a system property before executing, thus allowing it to be disabled dynamically.
The text was updated successfully, but these errors were encountered:
Yes that's the solution I have seen. I was more wondering about the case were we do not own the pom.xml and thus have to find a way that does not require it to change. Is that more of a convention problem with Maven and how the tools are generaly made?
## 📜 Description
<!--- Describe your changes in detail -->
Allow disabling source upload via `SENTRY_SKIP_SOURCE_UPLOAD` env var.
## 💡 Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Fixes#60
Source upload requires an auth token and fails the build without a valid
one. This allows disabling source upload without changing `pom.xml`
## 💚 How did you test it?
## 📝 Checklist
<!--- Put an `x` in the boxes that apply -->
- [ ] I reviewed the submitted code
- [ ] I added tests to verify the changes
- [ ] I updated the docs if needed
- [ ] No breaking changes
## 🔮 Next steps
Problem Statement
Maybe it's moe of a problem from Maven's end, but let's say you want to dockerize a project that is configured to upload Sentry source bundles, but you don't have a sentry Auth key or want to provide one during the image build, it would be nice to not have to mingle with the
pom.xml
configuration and simply be able to pass either an env variable or a property to disable the plugin.Solution Brainstorm
The text was updated successfully, but these errors were encountered: