Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable source upload via SENTRY_SKIP_SOURCE_UPLOAD env var #65

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Mar 22, 2024

📜 Description

Allow disabling source upload via SENTRY_SKIP_SOURCE_UPLOAD env var.

💡 Motivation and Context

Fixes #60

Source upload requires an auth token and fails the build without a valid one. This allows disabling source upload without changing pom.xml

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Mar 22, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 3e807a9

@adinauer
Copy link
Member Author

I think I just found a bug around isSaas check. Will fix first.

@adinauer adinauer marked this pull request as ready for review March 22, 2024 07:16
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit f20cab4 into main Mar 25, 2024
6 checks passed
@adinauer adinauer deleted the feat/disable-upload-via-env-var branch March 25, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling the plugin using the comand line
2 participants