Hotfix: Non-static method XXX::YYY should not be called statically (callable serialization issue) #815
Conversation
Ok, I'll add it shortly |
Done! |
| @@ -455,13 +456,17 @@ public function serializableCallableProvider(): array | |||
| 'callable' => $callableWithoutNamespaces, | |||
| 'expected' => 'Lambda void {closure} [int|null param1_70ns]', | |||
| ], | |||
| [ | |||
| 'callable' => $pseudoStaticMethod, | |||
| 'expected' => '{unserializable callable, reflection error}', | |||
There was a problem hiding this comment.
This doesn't seem an acceptable outcome...
|
I would say that this seems to be some strange behavior of the PHP core and that probably should be reported as a bug of the language instead of removing a typehint here. Not sure about it though |
| @@ -210,7 +210,7 @@ protected function serializeValue($value) | |||
| * | |||
| * @return string | |||
| */ | |||
| protected function serializeCallable(callable $callable): string | |||
| protected function serializeCallable($callable): string | |||
There was a problem hiding this comment.
As pointed out by @ste93cry in #821 (comment), this is a BC, we cannot remove the type hint...
|
Closing in favor of #821 |
Hi Team! There is a weird behavior conceived to
__METHOD__constant when we pass it through argument in our code. I'll try to explain.This piece of code:
https://github.com/getsentry/sentry-php/blob/master/src/Serializer/AbstractSerializer.php#L110
Guides to this method:
https://github.com/getsentry/sentry-php/blob/master/src/Serializer/AbstractSerializer.php#L213
The
callabletypehint will work incorrectly if__METHOD__refers to dynamic method. It will throw an error, and then this error will spoil the original stacktrace. That's not good at all.This snippet will show You the whole picture: http://sandbox.onlinephpfunctions.com/code/fba854e73f595f1fe78596f6bcc56371eba500b2
The error is:
How is it related to Sentry? If we enable Sentry for this code, and there will be an exception inside
demonstrate2, we will have one more exception in stacktrace while serializing the stacktrace, so it will be spoiled with weird internal error. Why? Because PHP will try to execute the callable if typehint is used. No idea why.TL;DR: the
callabletypehint must be disabled for safety.Thanks for attention!